Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate prod_curry and prod_uncurry #12716

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Conversation

liyishuai
Copy link
Member

@liyishuai liyishuai commented Jul 21, 2020

@liyishuai liyishuai requested a review from a team as a code owner July 21, 2020 02:02
@anton-trunov anton-trunov self-assigned this Jul 21, 2020
@anton-trunov anton-trunov added kind: cleanup Code removal, deprecation, refactorings, etc. kind: fix This fixes a bug or incorrect documentation. part: standard library The standard library stdlib. and removed kind: fix This fixes a bug or incorrect documentation. labels Jul 21, 2020
@Blaisorblade
Copy link
Contributor

Cool, thanks! Follow-up: Can a library be compatible with older Coqs, use these functions and avoid triggering warnings?

@liyishuai
Copy link
Member Author

Can a library be compatible with older Coqs, use these functions and avoid triggering warnings?

I know Java has @SuppressWarnings("deprecation"), maybe worth a Coq equivalent?

@anton-trunov anton-trunov added this to the 8.12.0 milestone Jul 22, 2020
@Zimmi48 Zimmi48 modified the milestones: 8.12.0, 8.13+beta1 Jul 23, 2020
@Zimmi48
Copy link
Member

Zimmi48 commented Jul 23, 2020

Yes, you should use Set Warnings "-foo". where foo is either the warning name or the warning category. You can also add Set Warnings "foo". afterwards to reactivate the warning for the rest of the file.

@anton-trunov
Copy link
Member

CI keeps failing for this PR. Can something be done here? Maybe a rebase would help if it has already been fixed on master?

@liyishuai
Copy link
Member Author

CI seems happy now.

@anton-trunov anton-trunov merged commit 226ed20 into coq:master Aug 13, 2020
@liyishuai liyishuai deleted the curry branch August 13, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: cleanup Code removal, deprecation, refactorings, etc. part: standard library The standard library stdlib.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants