Clean the constr-as-hint API #13139
Merged
Clean the constr-as-hint API #13139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppedrot
added a commit
to ppedrot/fiat
that referenced
this pull request
Oct 5, 2020
ppedrot
added a commit
to ppedrot/fiat-crypto
that referenced
this pull request
Oct 5, 2020
ppedrot
force-pushed
the
clean-hint-constr
branch
from
14482db
to
8dc9927
Compare
JasonGross
pushed a commit
to mit-plv/fiat-crypto
that referenced
this pull request
Oct 5, 2020
ppedrot
added a commit
to ppedrot/Coq-Equations
that referenced
this pull request
Oct 6, 2020
ppedrot
force-pushed
the
clean-hint-constr
branch
from
8dc9927
to
8dea8a7
Compare
ppedrot
added a commit
to ppedrot/Coq-Equations
that referenced
this pull request
Oct 14, 2020
ppedrot
force-pushed
the
clean-hint-constr
branch
2 times, most recently
from
f02ddb4
to
4eb7898
Compare
SkySkimmer
reviewed
Oct 14, 2020
|
@mattam82 would you assign? |
|
@mattam82 ping |
1 similar comment
|
@mattam82 ping |
We know statically that only global references are passed to make_resolves.
The prepare_hint function was trying to requantify over all undefined evars, but actually this should not happen when defining generic terms as hints through some Hint vernacular command.
We reuse the standard code path for term interpretation instead of trying to mangle it.
ppedrot
added a commit
to ppedrot/fiat
that referenced
this pull request
Nov 4, 2020
ppedrot
force-pushed
the
clean-hint-constr
branch
from
4eb7898
to
1241353
Compare
|
@SkySkimmer maybe then, since @mattam82 seems trapped in a spatio-temporal anomaly? |
|
Please link overlay PRs |
|
(Done.) |
|
@coqbot: merge now |
|
@SkySkimmer: Please take care of the following overlays:
|
ppedrot
added a commit
to mattam82/Coq-Equations
that referenced
this pull request
Nov 6, 2020
Adapt w.r.t. coq/coq#13139.
JasonGross
pushed a commit
to mit-plv/fiat
that referenced
this pull request
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hides internal details of the API allowing to declare arbitrary terms as hints. Furthermore, in order to reduce the underspecified behaviours exposed to the end-user, this changes the semantics of open terms added as hints. Before the PR, it would implicitly quantify over the dangling evars in a fragile way (amongst others sensitive to the evar naming), now it simply errors out and one needs to explicitly quantify over the remaining holes. Note that I've only found one place where this (undocumented) feature was used in the whole CI, namely in fiat-crypto.
Overlays: