-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for printing goal names in CoqIDE #13145
Merged
ppedrot
merged 2 commits into
coq:master
from
herbelin:master+coqide-printing-goal-names-support
Nov 2, 2020
Merged
Adding support for printing goal names in CoqIDE #13145
ppedrot
merged 2 commits into
coq:master
from
herbelin:master+coqide-printing-goal-names-support
Nov 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herbelin
added
part: CoqIDE
Issues and PRs related to CoqIDE or other IDE features of coq.
part: printer
The printing mechanism of Coq.
labels
Oct 6, 2020
3 tasks
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Oct 6, 2020
Zimmi48
added
the
kind: feature
New user-facing feature request or implementation.
label
Oct 6, 2020
Zimmi48
reviewed
Oct 6, 2020
doc/changelog/09-coqide/13145-master+coqide-printing-goal-names-support.rst
Outdated
Show resolved
Hide resolved
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Oct 6, 2020
Co-authored-by: Théo Zimmermann <theo.zimmi@gmail.com>
herbelin
force-pushed
the
master+coqide-printing-goal-names-support
branch
from
October 6, 2020 20:07
bd76202
to
fee0cae
Compare
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Oct 6, 2020
Co-authored-by: Théo Zimmermann <theo.zimmi@gmail.com>
herbelin
force-pushed
the
master+coqide-printing-goal-names-support
branch
from
October 6, 2020 20:41
fee0cae
to
81d1939
Compare
herbelin
added
the
needs: merge of dependency
This PR depends on another PR being merged first.
label
Oct 7, 2020
herbelin
removed
the
needs: merge of dependency
This PR depends on another PR being merged first.
label
Oct 28, 2020
herbelin
added a commit
to herbelin/github-coq
that referenced
this pull request
Oct 28, 2020
Co-authored-by: Théo Zimmermann <theo.zimmi@gmail.com>
herbelin
force-pushed
the
master+coqide-printing-goal-names-support
branch
from
October 28, 2020 18:54
81d1939
to
f8a1660
Compare
CI morally green (dpdgraph and macos are currently failing). |
ppedrot
reviewed
Oct 29, 2020
Co-authored-by: Théo Zimmermann <theo.zimmi@gmail.com> Co-authored-by: Pierre-Marie Pédrot <pierre-marie.pedrot@inria.fr>
Co-authored-by: Théo Zimmermann <theo.zimmi@gmail.com>
herbelin
force-pushed
the
master+coqide-printing-goal-names-support
branch
from
October 30, 2020 14:13
e63fcc8
to
05f8308
Compare
ppedrot
approved these changes
Nov 2, 2020
This was referenced Dec 18, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind: feature
New user-facing feature request or implementation.
part: CoqIDE
Issues and PRs related to CoqIDE or other IDE features of coq.
part: printer
The printing mechanism of Coq.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind: documentation / bug fix
Depends on #13140 (merged) for the correctness of the reference manual check.
This adds support for printing goal names in CoqIDE.
Incidentally, this invites to concoct names more informative than
?Goal
,?Goal0
...Note: The
Printing Goal Names
flag is tested on theidetop
side while thePrinting Unfocused
flag was tested on the coqide side. It is a bit inconsistent but I don't know precisely what would be the most relevant to do.