Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for printing goal names in CoqIDE #13145

Merged

Conversation

herbelin
Copy link
Member

@herbelin herbelin commented Oct 6, 2020

Kind: documentation / bug fix

Depends on #13140 (merged) for the correctness of the reference manual check.

This adds support for printing goal names in CoqIDE.

Incidentally, this invites to concoct names more informative than ?Goal, ?Goal0 ...

Note: The Printing Goal Names flag is tested on the idetop side while the Printing Unfocused flag was tested on the coqide side. It is a bit inconsistent but I don't know precisely what would be the most relevant to do.

  • Entry added in the changelog

@herbelin herbelin added part: CoqIDE Issues and PRs related to CoqIDE or other IDE features of coq. part: printer The printing mechanism of Coq. labels Oct 6, 2020
@herbelin herbelin added this to the 8.13+beta1 milestone Oct 6, 2020
@herbelin herbelin requested review from a team as code owners October 6, 2020 06:29
herbelin added a commit to herbelin/github-coq that referenced this pull request Oct 6, 2020
@Zimmi48 Zimmi48 added the kind: feature New user-facing feature request or implementation. label Oct 6, 2020
herbelin added a commit to herbelin/github-coq that referenced this pull request Oct 6, 2020
Co-authored-by: Théo Zimmermann <theo.zimmi@gmail.com>
@herbelin herbelin force-pushed the master+coqide-printing-goal-names-support branch from bd76202 to fee0cae Compare October 6, 2020 20:07
herbelin added a commit to herbelin/github-coq that referenced this pull request Oct 6, 2020
Co-authored-by: Théo Zimmermann <theo.zimmi@gmail.com>
@herbelin herbelin force-pushed the master+coqide-printing-goal-names-support branch from fee0cae to 81d1939 Compare October 6, 2020 20:41
@herbelin herbelin added the needs: merge of dependency This PR depends on another PR being merged first. label Oct 7, 2020
@ppedrot ppedrot self-assigned this Oct 7, 2020
@herbelin herbelin removed the needs: merge of dependency This PR depends on another PR being merged first. label Oct 28, 2020
herbelin added a commit to herbelin/github-coq that referenced this pull request Oct 28, 2020
Co-authored-by: Théo Zimmermann <theo.zimmi@gmail.com>
@herbelin herbelin force-pushed the master+coqide-printing-goal-names-support branch from 81d1939 to f8a1660 Compare October 28, 2020 18:54
@herbelin
Copy link
Member Author

CI morally green (dpdgraph and macos are currently failing).

ide/coqide/wg_ProofView.ml Outdated Show resolved Hide resolved
ide/coqide/wg_ProofView.ml Outdated Show resolved Hide resolved
herbelin and others added 2 commits October 30, 2020 15:12
Co-authored-by: Théo Zimmermann <theo.zimmi@gmail.com>
Co-authored-by: Pierre-Marie Pédrot <pierre-marie.pedrot@inria.fr>
Co-authored-by: Théo Zimmermann <theo.zimmi@gmail.com>
@herbelin herbelin force-pushed the master+coqide-printing-goal-names-support branch from e63fcc8 to 05f8308 Compare October 30, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: feature New user-facing feature request or implementation. part: CoqIDE Issues and PRs related to CoqIDE or other IDE features of coq. part: printer The printing mechanism of Coq.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants