Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag 8.13 beta1 #13587

Merged
merged 3 commits into from
Dec 7, 2020
Merged

Tag 8.13 beta1 #13587

merged 3 commits into from
Dec 7, 2020

Conversation

gares
Copy link
Member

@gares gares commented Dec 7, 2020

This should be it.
It's not super clear what "We generally do not update the magic numbers at this point." means. In which case should I do that?

@gares gares requested a review from Zimmi48 December 7, 2020 09:01
@gares gares requested a review from a team as a code owner December 7, 2020 09:01
@gares gares requested a review from a team December 7, 2020 09:01
@gares gares added this to the 8.13+beta1 milestone Dec 7, 2020
@gares gares added the kind: infrastructure CI, build tools, development tools. label Dec 7, 2020
@Zimmi48
Copy link
Member

Zimmi48 commented Dec 7, 2020

In which case should I do that?

This was just based on observing how previous beta were handled when I wrote this. I'm not the expert on magic numbers though, so this could be a discussion to have with other Coq devs.

@Zimmi48
Copy link
Member

Zimmi48 commented Dec 7, 2020

It looks like we're doomed! Homebrew has chosen to start failing again on all PRs since yesterday 😱

See https://dev.azure.com/coq/coq/_pipeline/analytics/stageawareoutcome?definitionId=1 (this looks like a 100% failure rate today with 4 failures, all during this step).

@gares
Copy link
Member Author

gares commented Dec 7, 2020

==> `brew cleanup` has not been run in 30 days, running now...
Error: Not a directory @ dir_s_rmdir - /usr/local/Cellar/openssl
Removing: /usr/local/Cellar/openssl/1.0.2t... (1,787 files, 12.0MB)

@gares
Copy link
Member Author

gares commented Dec 7, 2020

can we "reset" the workers on azure? I really don't know how these VMs are handled, but it seems that is the cleanup that fails

@Zimmi48
Copy link
Member

Zimmi48 commented Dec 7, 2020

I know very little about Azure. You have a whole bunch of settings that you can access here https://dev.azure.com/coq/coq/_settings/testmanagement after being logged in with GitHub though.

To add to the doom, it looks like the Windows job is failing as well: https://coq.gitlab.io/-/coq/-/jobs/894114063/artifacts/artifacts/buildlogs/ocaml-4.08.1-make-flexdll_err.txt

@gares
Copy link
Member Author

gares commented Dec 7, 2020

For windows we don't have the right job in CI yet. I can build it on my VM, and together with Michael we have been testing it, so it's OK.

@gares
Copy link
Member Author

gares commented Dec 7, 2020

@Zimmi48 , but for the failures, is the PR OK? I'd like to merge and tag.

@Zimmi48
Copy link
Member

Zimmi48 commented Dec 7, 2020

Sure but you have another strategy to produce the macOS installer once this is tagged if we don't manage to fix the Azure failure without changing the configuration itself? (Like asking a Coq developer on macOS to produce the installer?)

@gares
Copy link
Member Author

gares commented Dec 7, 2020

I have an installer build on azure that has the only difference in the contents of this PR (version number). So the scripts are not too broken.
As soon as I tag I can ask on zulip if Matthieu can build it, for example.

@gares gares requested a review from a team as a code owner December 7, 2020 12:19
@gares
Copy link
Member Author

gares commented Dec 7, 2020

OSX is back on track

@gares gares merged commit 5f7bf8d into coq:v8.13 Dec 7, 2020
@gares gares deleted the tag_8.13_beta1 branch December 7, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: infrastructure CI, build tools, development tools.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants