Nix CI: follow-up of #14590. #14723
Merged
Nix CI: follow-up of #14590. #14723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coq-shell is a fake package which depends on Coq. For some reason I do not understand, while Coq is built on CI, it is not uploaded to Cachix and not required when fetching coq-shell from Cachix.
Zimmi48
added
kind: infrastructure
Zimmi48
force-pushed
the
toolbox-deploy-adjustments
branch
from
85b2f86
to
c8dfb0a
Compare
Coq is now a managed Cachix so this variable should be defined and we check for its presence. This will avoid failures when building on forks where this is not defined.
Zimmi48
force-pushed
the
toolbox-deploy-adjustments
branch
from
c8dfb0a
to
43ab865
Compare
1 task
|
ping @CohenCyril |
This was referenced Aug 6, 2021
Maybe that's because |
CohenCyril
approved these changes
Oct 8, 2021
|
@coqbot merge now!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build only Coq and not
coq-shell.For some reason I do not understand, while Coq is built on CI, it is not uploaded to Cachix and not required when fetching
coq-shellfrom Cachix.Cf. https://gitlab.com/coq/coq/-/jobs/1464705325 (first success) vs https://gitlab.com/coq/coq/-/jobs/1465481056 (retry).
Test that
CACHIX_AUTH_TOKENis set to runpkg:nix:deploy.Coq has now a managed Cachix so this variable should be defined and we check for its presence. This will avoid failures when building on forks where it is not defined.
CACHIX_AUTH_TOKENset at: https://gitlab.com/Zimmi48/coq/-/pipelines/345552922 (nopkg:nix:deployjob)CACHIX_AUTH_TOKENset at: https://gitlab.com/Zimmi48/coq/-/pipelines/345554673 (there is apkg:nix:deployjob).