-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[primitive floats] Deprecate frexp and ldexp #15085
Conversation
6b67ad9
to
fdbcaac
Compare
I am confused. I thought |
Those are called |
Thanks @proux01 for opening this. However, I am wondering whether one such renaming could be done in a more "modular" way (like the BinInt theory)? I mean, renaming |
fdbcaac
to
f26000a
Compare
Indeed, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @proux01, this looks fine (except two lines that needs an update)
f26000a
to
e27bb79
Compare
Thanks, it seems the changelog is the last missing part |
e27bb79
to
40e92aa
Compare
Now that we have signed primitive integers, we would like to use them in frexp and ldexp but the name was taken by functions with exponent in Z. These functions are renamed frZexp and ldZexp so that frexp and ldexp could later be added with signed primitive integer exponent. Co-authored-by: Erik Martin-Dorel <erik.martin-dorel@irit.fr>
@erikmd done, would you be the assignee? |
Sure. If no one objects, I propose to merge this cleanup PR on tomorrow Wednesday evening. |
@coqbot merge now |
@erikmd: You can't merge this PR because you're not a member of the |
@silene can you be the assignee then? |
Oh, let us fix this @erikmd |
@erikmd not sure what's the best team for "primitive floats maintainers", I've added you to the vm-native-maintainers for now, but let's refine this if needed; please try again. |
And sorry for the annoyance. |
Indeed; thank you @ejgallego!
No worries! (I think the infrastructure was refactored since my last merge - #14688 (comment)) |
@coqbot merge now |
Thanks @erikmd (and thanks @ejgallego ) |
Now that we have signed primitive integers, we would like to use them
in frexp and ldexp but the name was taken by functions with exponent
in Z. These functions are renamed Z.frexp and Z.ldexp so that frexp and
ldexp could later be added with signed primitive integer exponent.