Fixes #18163: respect "Set Printing implicit" in patterns #18176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herbelin
added
kind: fix
coqbot-app
bot
added
the
needs: full CI
SkySkimmer
reviewed
Oct 18, 2023
| eq_sym = | ||
| fun (A : Type) (x y : A) (H : x = y) => | ||
| match H in (_ = a) return (a = x) with | ||
| | @eq_refl _ _ => @eq_refl A x |
There was a problem hiding this comment.
Is this correct with asymmetric patterns?
There was a problem hiding this comment.
I was surprised but apparently yes. This was a change between Coq 8.4 to 8.5 (at the time of the asymmetric change).
8.4:
Check fun l:list nat => match l with nil => nil | @cons _ _ _ => @nil nat end.failsCheck fun l:list nat => match l with nil => nil | @cons _ _ => @nil nat end.works
8.5:
Check fun l:list nat => match l with nil => nil | @cons _ _ _ => @nil nat end.worksCheck fun l:list nat => match l with nil => nil | @cons _ _ => @nil nat end.fails
herbelin
added
the
request: full CI
herbelin
force-pushed
the
master+fix18163-implicit-in-patterns
branch
from
e24d8f7
to
02386ba
Compare
coqbot-app
bot
removed
request: full CI
SkySkimmer
approved these changes
Oct 18, 2023
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set Printing implicit/Set Printing Allin patterns was actually not supported.Fixes / closes #18163