New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #18163: respect "Set Printing implicit" in patterns #18176
Merged
coqbot-app
merged 4 commits into
coq:master
from
herbelin:master+fix18163-implicit-in-patterns
Oct 18, 2023
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d6201ff
Formatting code in constrextern.ml (no semantical change).
herbelin b2d44d1
Removing obsolete code in constrextern.ml (from Coq V7).
herbelin 3fd711b
Fixes #18163: take implicit-printing mode into account for patterns.
herbelin 02386ba
Add change log for #18176
herbelin File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
...ngelog/02-specification-language/18176-master+fix18163-implicit-in-patterns.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
- **Fixed:** | ||
Printing of constructors and of :g:`in` clause of :g:`match` now respects the | ||
:flag:`Printing Implicit` and :flag:`Printing All` flags | ||
(`#18176 <https://github.com/coq/coq/pull/18176>`_, | ||
fixes `#18163 <https://github.com/coq/coq/issues/18163>`_, | ||
by Hugo Herbelin). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct with asymmetric patterns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was surprised but apparently yes. This was a change between Coq 8.4 to 8.5 (at the time of the asymmetric change).
8.4:
Check fun l:list nat => match l with nil => nil | @cons _ _ _ => @nil nat end.
failsCheck fun l:list nat => match l with nil => nil | @cons _ _ => @nil nat end.
works8.5:
Check fun l:list nat => match l with nil => nil | @cons _ _ _ => @nil nat end.
worksCheck fun l:list nat => match l with nil => nil | @cons _ _ => @nil nat end.
fails