New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated clear modifier. #18887
Conversation
121a671
to
ff58952
Compare
I will write a cleanup following this removal, but I prefer having this PR separate. |
I may have missed a discussion, but what are the objections against a clear modifier? It seems to me to be a useful feature. |
It has been deprecated since 8.17, long enough for people to have realized this.
ff58952
to
c4e2ac0
Compare
The discussion was more about the syntactic and semantics difference between ssr and vanilla for the clear feature, not about the principle of such feature. I feel uncomfortable to take such kind of decision of removal of an a-priori useful feature without a prior vision of where we are going in general regarding tactics. Also, I'd like to remind that if I did not document and advertise the clear flag further, and did not fully develop it, it was precisely in the hope of a discussion about what is our vision about tactics (especially after the trauma that the implementation of the My perception is that we are postponing for many years the question of what is our model regarding tactics. I'm unsure we can afford continuing postponing it. I hope the discussion on the long-term roadmap will help us communicating between us. |
@@ -0,0 +1,4 @@ | |||
- **Removed:** | |||
the clear modifier which was deprecated since 8.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the clear modifier which was deprecated since 8.17 | |
the :n:`clear` modifier which has been deprecated since 8.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite having a similar behaviour, this is not the clear tactic, so I'm not sure we want to do this. The previous changelog entry did not have a special rendering for this word (see #16407).
PS: My previous remarks applied to the code of the clear modifier. Deactivating the parsing rule is consistent with #16407. |
@herbelin so there is no problem with this PR per se then? |
@coqbot merge now |
It has been deprecated since 8.17, long enough for people to have realized this.