Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the deprecated clear modifier. #18887

Merged
merged 2 commits into from Apr 5, 2024
Merged

Remove the deprecated clear modifier. #18887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da4f6bc
Remove the deprecated clear modifier.
ppedrot Apr 3, 2024
c4e2ac0
Fix grammar file.
ppedrot Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/changelog/04-tactics/18887-rm-deprecated-clear-modifier.rst
View file
Open in desktop
@@ -0,0 +1,4 @@
- **Removed:**
the clear modifier which was deprecated since 8.17
Copy link
Member

@jfehrle jfehrle Apr 4, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
the clear modifier which was deprecated since 8.17
the :n:`clear` modifier which has been deprecated since 8.17

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite having a similar behaviour, this is not the clear tactic, so I'm not sure we want to do this. The previous changelog entry did not have a special rendering for this word (see #16407).

(`#18887 <https://github.com/coq/coq/pull/18887>`_,
by Pierre-Marie Pédrot).
4 changes: 0 additions & 4 deletions doc/tools/docgram/common.edit_mlg
View file
Open in desktop
Expand Up @@ -2182,10 +2182,6 @@ cofixdecl: [

OPTINREF: [ ]

constr_with_bindings_arg: [
| DELETE ">" constr_with_bindings
]

destruction_arg: [
| DELETE constr_with_bindings
]
Expand Down
1 change: 0 additions & 1 deletion doc/tools/docgram/fullGrammar
View file
Open in desktop
Expand Up @@ -2364,7 +2364,6 @@ destruction_arg: [
]

constr_with_bindings_arg: [
| ">" constr_with_bindings
| constr_with_bindings
]

Expand Down
10 changes: 1 addition & 9 deletions plugins/ltac/g_tactic.mlg
View file
Open in desktop
Expand Up @@ -198,11 +198,6 @@ let deprecated_conversion_at_with =
~name:"conversion_at_with" ~category:Deprecation.Version.v8_14
(fun () -> Pp.str "The syntax [at ... with ...] is deprecated. Use [with ... at ...] instead.")

let deprecated_clear_modifier =
CWarnings.create
~name:"deprecated-clear-modifier" ~category:Deprecation.Version.v8_17
(fun () -> Pp.strbrk "The undocumented clear modifier \">\" is deprecated. Open an issue at https://github.com/coq/coq/issues/new if you actually depend on this feature in your work.")

(* Auxiliary grammar rules *)

open Pvernac.Vernac_
Expand Down Expand Up @@ -240,10 +235,7 @@ GRAMMAR EXTEND Gram
] ]
;
constr_with_bindings_arg:
[ [ ">"; c = constr_with_bindings ->
{ deprecated_clear_modifier (); (* 8.17 *)
(Some true,c) }
| c = constr_with_bindings -> { (None,c) } ] ]
[ [ c = constr_with_bindings -> { (None,c) } ] ]
;
quantified_hypothesis:
[ [ id = ident -> { NamedHyp (CAst.make ~loc id) }
Expand Down