New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GHC.Base.Any for compatibility with GHC 8.2 #6023
Conversation
The GHC issue (Trac 10886) doesn't really resolve the backwards compatibility issue. It looks like I'd like to check that this works in GHC 7 and then I'm happy with this solution, even though it's somewhat unclear to me what GHC wants users to do. The alternative is to use |
Also here's a test case that triggers a use of Require Import Extraction.
Inductive expr : Type -> Type :=
| bind : forall T T', expr T -> expr T'.
Extraction Language Haskell.
Extraction "expr.hs" expr. |
@letouzey Could you review this PR? Thanks! |
@letouzey ping |
@letouzey Would you have some time to look at this PR? |
I actually want this patch at least in Coq master, since Arch uses GHC 8.2. Is there anybody else with some basic knowledge of Haskell to review this? I've now tested this example on GHC 7.10.3, 8.0.2, and 8.2.1. If somebody wants to reproduce (which I imagine is the only blocker to merging), use Stack resolvers |
Maxime has asked a review from @letouzey because he is kind of "the guardian of the temple" when it comes to Extraction. However, given the triviality of this patch, given that it has been pending for more than 20 days, and given that it was extensively tested by @tchajed, I say this should get merged without waiting more. |
Sounds good, will merge then, thanks! |
Thanks for your contribution and your patience, @tchajed ! |
Fixes #6022.
Thanks @bmsherman for identifying the issue!