-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git / gpg integration link #7519
Conversation
Actually there are more general instructions
dev/doc/MERGING.md
Outdated
@@ -111,7 +111,8 @@ The merge script passes option `-S` to `git merge` to ensure merge commits | |||
are signed. Consequently, it depends on the GnuPG command utility being | |||
installed and a GPG key being available. Here is a short tutorial to | |||
creating your own GPG key: | |||
<https://ekaia.org/blog/2009/05/10/creating-new-gpgkey/> | |||
<https://ekaia.org/blog/2009/05/10/creating-new-gpgkey/>. To link it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we link some random blog instead of https://help.github.com/articles/generating-a-new-gpg-key/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because that's the doc recommended by Debian. But it feels like a good idea to change it to the link you gave. Especially since it includes "step 14: add the GPG key to your GitHub account".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So given @SkySkimmer's remark above and given that the link you added is the general summary page on GitHub and not the specific link https://help.github.com/articles/telling-git-about-your-gpg-key/ that you gave on Gitter, I would say that either the two links are redundant and we should only provide https://help.github.com/articles/signing-commits-with-gpg/, or we want to point to more specific things and in this case https://help.github.com/articles/generating-a-new-gpg-key/ + https://help.github.com/articles/telling-git-about-your-gpg-key/ seems like the right combination (and links to the other pages are at the bottom of these pages anyways).
dev/doc/MERGING.md
Outdated
@@ -111,7 +111,8 @@ The merge script passes option `-S` to `git merge` to ensure merge commits | |||
are signed. Consequently, it depends on the GnuPG command utility being | |||
installed and a GPG key being available. Here is a short tutorial to | |||
creating your own GPG key: | |||
<https://ekaia.org/blog/2009/05/10/creating-new-gpgkey/> | |||
<https://ekaia.org/blog/2009/05/10/creating-new-gpgkey/>. To link it with | |||
git & github, follow https://help.github.com/articles/signing-commits-with-gpg/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proper casing is GitHub.
Simpler
I simplified, that should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@mattam82 Be careful that by using GitHub edit feature, you actually created a new branch on the main repo instead of your fork. |
Kind: documentation