Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opam files for coq-metacoq version 1.2.1 for Coq 8.17 and 8.18 #2809

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

yforster
Copy link
Contributor

@yforster yforster commented Nov 1, 2023

No description provided.

@yforster yforster mentioned this pull request Nov 1, 2023
1 task
@palmskog
Copy link
Contributor

palmskog commented Nov 1, 2023

@yforster please add the following line at the top of every .opam file:

opam-version: "2.0"

@palmskog
Copy link
Contributor

palmskog commented Nov 1, 2023

@yforster CI will easily time out on both 8.17 and 8.18, possibly missing some packages. If I merge this PR after timeout, could you double check locally that both sets of packages install properly?

@yforster
Copy link
Contributor Author

yforster commented Nov 1, 2023

I added the opam-version line, thanks

@yforster
Copy link
Contributor Author

yforster commented Nov 1, 2023

Can I double check already before you merge? Or do I need to wait for the packages to appear in the released repo?

@palmskog
Copy link
Contributor

palmskog commented Nov 1, 2023

It would be nice if we could get a check after the merge (after locally running opam update), since weird things can go wrong with opam and package constraints...

@yforster
Copy link
Contributor Author

yforster commented Nov 1, 2023

Locally, running opam repo add test . on a new switch and then installing both coq-metacoq.1.2.1+8.17 and coq-metacoq.1.2.1+8.18 works fine. I'll double check after the merge, but everything should work. Also, I just discovered that https://coq.inria.fr/opam-packaging.html exists and I think that's a great explanation :)

@palmskog palmskog merged commit 6e0612f into coq:master Nov 1, 2023
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants