Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request for aliases (coqide and coq_makefile) is ongoing here: https://forum.snapcraft.io/t/aliases-request-for-coq-prover/21925
@MSoegtropIMC this is now ready for review. There are a few things to document:
github_actions/run_snap.sh
can do it. The idea is that the job is run "in full" only when one wants to upload to the store, otherwise a minimal (quicker) thing is build but not uploaded. Saving the artifact is orthogonal to uploading to the store. Uploading to the store does not make the snap public, there is a pipeline (I still have to test) to move fromedge
tobeta
and then tostable
a package by hand. So it is not the end of the world if one uploads by mistake, but it is just a waste I believe.A few point to discuss:
linux/create_linux_installer.sh
but alsosnap/
containing templates and the result of calling the first script, is it ok? In general this PR creates 3 directories, maybe it's too much.Improvements we could do:
The package is still private, here a preview: