-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Phoneme extraction with punctuations is wrongly delimited #771
Comments
I'm reworking parts of gruut's tokenization pipeline to preserve whitespace. I'll delay updating the current pull request until these changes are in. |
@erogol would love to see it in the next minor version update, please. |
It is pretty much in the hands of @synesthesiam |
I'm working on it! I have this pesky job that keeps taking my time 😉 This is taking longer than expected since I'm adding it and preliminary SSML support at this same time. It didn't seem worth it to me to redo the existing gruut tokenizer (to add proper whitespace preservation) only to scrap it later for SSML. I will be completing the changes to gruut this week, and my goal is to have it integrated and tested with 🐸 TTS by 1 Oct 👍 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels. |
I think Gruut 2 adresses this right @synesthesiam |
Yes, the punctuation doesn't have whitespace artificially added now. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels. |
I close this as it's been fixed by the latest Gruut |
Describe the bug
Punctuations in extracted phonemes are delimited wrongly.
For instance the sentence
tuː foːɹ paʊndz , bʌt hɛviɚ aɪɚnz ,
should betuː foːɹ paʊndz, bʌt hɛviɚ aɪɚnz,
So punctuations do not need a space preceding them.
I think the current implementation causes unnatural silences in the trained models.
The text was updated successfully, but these errors were encountered: