-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gruut to version 2.0 #882
Conversation
Python 3.6 bug was fixed in gruut 2.0.1. Re-running the checks should pass now. |
1 similar comment
Python 3.6 bug was fixed in gruut 2.0.1. Re-running the checks should pass now. |
TTS/tts/utils/text/__init__.py
Outdated
word_phonemes = [] | ||
|
||
for word_phoneme in word.phonemes: | ||
word_phonemes.append(IPA.without_stress(word_phoneme).translate(GRUUT_TRANS_TABLE)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can make "stress" use optional by reflecting it to the model configs.
@synesthesiam do you plan to address the linter issue? |
755b174
to
59e6ae3
Compare
@synesthesiam do you have any docs about what is diff in Gruut 2.0 to link from the release notes? |
Sure, the release notes give a very brief summary of the changes. The docs go into detail, but don't contrast with v1. Internally, gruut has changed significantly. I haven't written up anything about it yet, but I'd be happy to if you think any TTS users would find it useful. |
I think it'd be useful to know what changed internally |
I've written up a small example here: https://rhasspy.github.io/gruut/#how-it-works |
I'll merge this after fixing a couple of bugs |
@synesthesiam I guess due to my force push, you have recurring commits in your commit tree. Can you rebase the code to remove them? Sorry for the inconvenience. |
4d76522
to
5281278
Compare
5281278
to
d033421
Compare
|
||
# Use gruut for phonemization | ||
ph_list = [] | ||
for sentence in gruut.sentences(text, lang=language, espeak=use_espeak_phonemes): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TTS used to have similar phonemization
for times builtin, have those been removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am talking about TTS/tts/utils/text/time.py
Minimal modifications for the update to gruut 2.0.
For the future: gruut's text processing has been greatly expanded in 2.0, and the current text cleaners in 🐸 TTS interfere. For example, the sentence:
gets expanded via
phoneme_cleaners
to:One way to solve this problem would be to use gruut itself as a text cleaner:
which gets you: