-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix in MP3 and FLAC compute length on TTSDataset #3092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I guess a test that checks that each of the 3 ostensibly supported formats actually works (both get_audio_size
and loading-wise) would be useful...
Yeah, I added a unit test that loads with all supported audio formats. And also call |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like the Trainer PR coqui-ai/Trainer#131 brokes the aux tests |
75066bb
to
02ff6f4
Compare
Co-authored-by: Aarni Koskela <akx@iki.fi>
49140dd
to
e741cab
Compare
Bug fix in MP3 and FLAC compute length on TTSDataset (coqui-ai#3092)
No description provided.