Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in MP3 and FLAC compute length on TTSDataset #3092

Merged
merged 9 commits into from
Dec 27, 2023
Merged

Conversation

Edresson
Copy link
Contributor

No description provided.

TTS/tts/datasets/dataset.py Outdated Show resolved Hide resolved
TTS/tts/datasets/dataset.py Outdated Show resolved Hide resolved
@Edresson Edresson requested a review from akx November 7, 2023 13:38
Copy link
Contributor

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I guess a test that checks that each of the 3 ostensibly supported formats actually works (both get_audio_size and loading-wise) would be useful...

@Edresson
Copy link
Contributor Author

Edresson commented Nov 7, 2023

Nice! I guess a test that checks that each of the 3 ostensibly supported formats actually works (both get_audio_size and loading-wise) would be useful...

Yeah, I added a unit test that loads with all supported audio formats. And also call get_audio_size function.

@Edresson Edresson requested a review from akx November 7, 2023 17:09
Copy link
Contributor

@WeberJulian WeberJulian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TTS/tts/datasets/dataset.py Outdated Show resolved Hide resolved
@Edresson Edresson changed the title Bug fix in MP3 length on TTSDataset Bug fix in MP3 and FLAC compute length on TTSDataset Nov 8, 2023
@Edresson
Copy link
Contributor Author

Edresson commented Dec 6, 2023

Looks like the Trainer PR coqui-ai/Trainer#131 brokes the aux tests

@Edresson Edresson merged commit 5dcc16d into dev Dec 27, 2023
49 checks passed
Pranjalya added a commit to Pranjalya/TTS that referenced this pull request Dec 29, 2023
Bug fix in MP3 and FLAC compute length on TTSDataset (coqui-ai#3092)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants