Finish mysql to mysqli conversion #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| public function escapeString($value) { | ||
| return mysql_real_escape_string($value); | ||
| return $this->db->escapeString($value); |
There was a problem hiding this comment.
^^^^^^^^^^
That was fixed in a latter commit.
893abdb#diff-5cf75f5d32772b1eb7e42cb21acede85L61
|
I reviewed the code, and everything seems ok for me. Can someone else have a look at this? |
And add spaces before openning curly brackets
the process was the same as: ndlibersa/resources@26ae17c (saved on https://archive.is if repo is deleted)
And add spaces before openning curly brackets
The process was the same as: ndlibersa/resources@26ae17c (saved on https://archive.is if repo is deleted) And fix error in management conversion
mysql was fine with: WHERE c.`licenseID`= whereas mysqli throws a syntax error and needs: WHERE c.`licenseID`='' Part of coral-erm#54
To avoid regressions because mysql was fine with: WHERE c.`licenseID`= whereas mysqli throws a syntax error and needs: WHERE c.`licenseID`='' This is preventive and not in response to observed regressions. Also it improves consistency as most of Coral's SQL building use this form for WHERE parameters. Part of coral-erm#54
tuxayo
force-pushed
the
gh54_mysql_to_mysqli_conversion
branch
from
9896574
to
b047ac5
Compare
|
I was able to install the module and create a document. The mysqli database connections seem to be working correctly. I'll go ahead and merge it. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look at the diffs commit by commit. Because before doing more than trivial editions to a file, I fixed the coding style on a separate commit so that the diffs are clean (and hopefully easier to review).
Part of #54