-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
php 7 compatibility #54
Comments
CORAL doesn't officially support PHP 7, but the mysql vs. mysqli is an issue. It appears that the management module never had its mysql functions converted to mysqli. This includes the installer, but also DBService.php. If you are going to attempt to update it, would you be willing to do the whole module? |
That's what I planned to do if I manage to understand well enough the conversion process. |
the process was the same as: ndlibersa/resources@26ae17c (saved on https://archive.is if repo is deleted)
the process was the same as: ndlibersa/resources@26ae17c (saved on https://archive.is if repo is deleted)
The process was the same as: ndlibersa/resources@26ae17c (saved on https://archive.is if repo is deleted) And fix error in management conversion
The process was the same as: ndlibersa/resources@26ae17c (saved on https://archive.is if repo is deleted) And fix error in management conversion
the process was the same as: ndlibersa/resources@26ae17c (saved on https://archive.is if repo is deleted)
The process was the same as: ndlibersa/resources@26ae17c (saved on https://archive.is if repo is deleted) And fix error in management conversion
mysql was fine with: WHERE c.`licenseID`= whereas mysqli throws a syntax error and needs: WHERE c.`licenseID`='' Part of coral-erm#54
To avoid regressions because mysql was fine with: WHERE c.`licenseID`= whereas mysqli throws a syntax error and needs: WHERE c.`licenseID`='' Part of coral-erm#54
To avoid regressions because mysql was fine with: WHERE c.`licenseID`= whereas mysqli throws a syntax error and needs: WHERE c.`licenseID`='' This is preventive and not in response to observed regressions. Also it improves consistency as most of Coral's SQL building use this form for WHERE parameters. Part of coral-erm#54
the process was the same as: ndlibersa/resources@26ae17c (saved on https://archive.is if repo is deleted)
The process was the same as: ndlibersa/resources@26ae17c (saved on https://archive.is if repo is deleted) And fix error in management conversion
mysql was fine with: WHERE c.`licenseID`= whereas mysqli throws a syntax error and needs: WHERE c.`licenseID`='' Part of coral-erm#54
To avoid regressions because mysql was fine with: WHERE c.`licenseID`= whereas mysqli throws a syntax error and needs: WHERE c.`licenseID`='' This is preventive and not in response to observed regressions. Also it improves consistency as most of Coral's SQL building use this form for WHERE parameters. Part of coral-erm#54
Just for anyone wondering, as #75 has been merged in the master branch, (code candidate for the next release) there is initial PHP 7 support. |
I think CORAL supports PHP 7 now. If future issues are identified that cause issues with that particular version of PHP, we'll open new issues to deal with them. We officially support PHP 5.5 and higher with 2.0.0 |
When setting up the project with PHP 7
And running going to /management/install/
I see in the logs
Call to undefined function mysql_connect() in /srv/http/coral/management/install/CORALInstaller.php:35
Which is a function of the mysql PHP extension
Which has been removed in PHP 7, as summed up here
There was already work done in the admin and install modules.
Grepping in the code shows that the Management and Report module are the last places using
mysql_connect()
andmysql_query()
I'll try to migrate them using the existing work.
The text was updated successfully, but these errors were encountered: