-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lang: programdata_address field for Program account #1125
lang: programdata_address field for Program account #1125
Conversation
lang/src/program.rs
Outdated
use solana_program::instruction::AccountMeta; | ||
use solana_program::program_error::ProgramError; | ||
use solana_program::pubkey::Pubkey; | ||
use std::fmt; | ||
use std::ops::Deref; | ||
|
||
// TODO: can we remove _account? | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any use to this field, considering that it's going to be empty struct all of the time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the type is needed for the id()
function. Though a better way of doing might be with PhantomData
. Can consider that for a separate PR though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes that sounds better to me. #1140
No description provided.