-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use rustls in reqwest dep #2385
Conversation
@kevinheavey is attempting to deploy a commit to the coral-xyz Team on Vercel. A member of the Team first needs to authorize it. |
Great, so these changes just narrow down the features that anchor uses? Can you say more about what |
The default native-tls feature of reqwest relies on OpenSSL being installed, which is not something Cargo can take care of for you (hence why the Anchor docs tell you to install a bunch of Linux packages). Solana crates like cargo-build-bpf already use the rustls feature though so I'm not worried about those disadvantages. A changelog entry would be good so people can take a step out of their workflows if needed |
Ok, well if it's good enough for cargo-build-bpf, then it's probably good enough for us. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Getting this error when trying to squash and merge. Very odd |
Github keeps erroring when trying to merge this PR, so just going to remake it in a new PR and merge that instead. |
This should remove the need for libssl, or at least remove two things that require it