Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Update: Firehose, Data Reference Resources (s3, iam), Ingress Url & AP3 region changes #175

Merged
merged 14 commits into from
Sep 10, 2024

Conversation

ryantanjunming
Copy link
Contributor

@ryantanjunming ryantanjunming commented Sep 2, 2024

Description

💡 Enhancements

  • Add AO3 region to the list of regions
  • Added custom naming for global resources
  • Added ability to import global resources (s3 & iam)

🛑 Breaking changes 🛑

  • For firehose-logs & firehose-metrics, Update variables: coralogix_region values regions from [Europe, Europe2, India, Singapore, US, US2] to [EU1, EU2, AP1, AP2, AP3, US1, US2]
  • Update variables: private_key renamed to api_key with type string instead of any.

How Has This Been Tested?

Locally with aws account

Checklist:

  • I have updated the relevant example in the examples directory for the module.
  • I have updated the relevant test file for the module.
  • This change does not affect module (e.g. it's readme file change)

@ryantanjunming ryantanjunming requested a review from a team as a code owner September 2, 2024 03:53
@CLAassistant
Copy link

CLAassistant commented Sep 4, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ guyrenny
❌ ryantanjunming
You have signed the CLA already but the status is still pending? Let us recheck it.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
modules/firehose-metrics/variables.tf Outdated Show resolved Hide resolved
@ryantanjunming ryantanjunming changed the title Feature Update: firehose logs, ingress & AP3 region Feature Update: firehose, ingress & AP3 region Sep 9, 2024
@ryantanjunming ryantanjunming changed the title Feature Update: firehose, ingress & AP3 region Feature Update: Firehose, ingress Url & AP3 region Sep 9, 2024
@ryantanjunming ryantanjunming changed the title Feature Update: Firehose, ingress Url & AP3 region Feature Update: Firehose, Data Reference Resources (s3, iam), Ingress Url & AP3 region changes Sep 9, 2024
@ryantanjunming ryantanjunming merged commit 659821d into master Sep 10, 2024
6 of 7 checks passed
Copy link

🎉 This PR is included in version 1.0.108 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants