Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORL-668] User Comment Rate Limiting #2616

Merged
merged 6 commits into from Oct 3, 2019
Merged

[CORL-668] User Comment Rate Limiting #2616

merged 6 commits into from Oct 3, 2019

Conversation

wyattjoh
Copy link
Collaborator

@wyattjoh wyattjoh commented Oct 3, 2019

This adds a rate limit to users so that they can only write one comment every 30 seconds.

@wyattjoh wyattjoh added this to the v5.2.0 milestone Oct 3, 2019
@wyattjoh wyattjoh requested review from cvle and tessalt and removed request for cvle October 3, 2019 00:32
tessalt
tessalt approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@tessalt tessalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like its a bit unintuitive that the return value of the update timestamp method is used to determine if a user should be rate limited... but I can't think of a solution that doesn't have a downside. LGTM

@wyattjoh wyattjoh merged commit 6fe4646 into master Oct 3, 2019
@wyattjoh wyattjoh deleted the feature/CORL-668 branch October 3, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tessalt tessalt tessalt approved these changes

@cvle cvle Awaiting requested review from cvle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v5.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wyattjoh @tessalt