[CORL-8] prevent repeat comments #2632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattjoh
requested changes
Oct 15, 2019
Comment on lines
32
to
37
| // We can only check for spam if this comment originated from a graphql | ||
| // request via an HTTP call. | ||
| if (!req) { | ||
| log.debug("request was not available"); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Not required as req isn't used in this phase
|
updated, the "re-request" button isn't showing up |
wyattjoh
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Question: the expiration of the last id in redis... it makes sense in this context but I'm wondering if we might want this to be more general-purpose and have the ID not expire and instead compare the createdAt in the moderation step? But then we're storing one entry indefinitely per user in redis and that could be a lot?
How to test: