Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design pass tweaks #269

Merged
merged 28 commits into from Feb 2, 2017
Merged

Design pass tweaks #269

merged 28 commits into from Feb 2, 2017

Conversation

okbel
Copy link
Contributor

@okbel okbel commented Jan 30, 2017

What does this PR do?

Solves this list of issues https://www.pivotaltracker.com/story/show/137362063

@kgardnr
Copy link
Contributor

kgardnr commented Jan 30, 2017

2 things:

  • Settings not showing for Commenter user
  • Cursor on usernames when they don't have bios

@okbel
Copy link
Contributor Author

okbel commented Jan 30, 2017

@kgardnr The settings thing turned out to be a BE thing. @wyattjoh it's working on it :) The cursor should be working. (If you don't have Bio, then your username it's not clickable. If you have a bio, you have a tiny triangle and it's clickable)

@kgardnr
Copy link
Contributor

kgardnr commented Jan 31, 2017

Excellent! Thanks @okbel!! 💯

@okbel okbel self-assigned this Feb 2, 2017
@okbel
Copy link
Contributor Author

okbel commented Feb 2, 2017

@wyattjoh I'm getting
screen shot 2017-02-02 at 8 00 17 am

TypeError: Cannot read property 'load' of undefined
    at comments (/Users/bel/Develop/talk/graph/resolvers/user.js:10:36)
    at resolveOrError (/Users/bel/Develop/talk/node_modules/graphql/execution/execute.js:473:12)
    at resolveField (/Users/bel/Develop/talk/node_modules/graphql/execution/execute.js:459:16)
    at /Users/bel/Develop/talk/node_modules/graphql/execution/execute.js:273:18
    at Array.reduce (native)
    at executeFields (/Users/bel/Develop/talk/node_modules/graphql/execution/execute.js:270:42)
    at completeObjectValue (/Users/bel/Develop/talk/node_modules/graphql/execution/execute.js:688:10)
    at completeValue (/Users/bel/Develop/talk/node_modules/graphql/execution/execute.js:597:12)
    at completeValueWithLocatedError (/Users/bel/Develop/talk/node_modules/graphql/execution/execute.js:517:21)
    at completeValueCatchingError (/Users/bel/Develop/talk/node_modules/graphql/execution/execute.js:493:21)
    at resolveField (/Users/bel/Develop/talk/node_modules/graphql/execution/execute.js:461:10)
    at /Users/bel/Develop/talk/node_modules/graphql/execution/execute.js:273:18
    at Array.reduce (native)
    at executeFields (/Users/bel/Develop/talk/node_modules/graphql/execution/execute.js:270:42)
    at executeOperation (/Users/bel/Develop/talk/node_modules/graphql/execution/execute.js:211:10)
    at /Users/bel/Develop/talk/node_modules/graphql/execution/execute.js:119:13
POST /api/v1/graph/ql 200 17.690 ms - -

When I hit settings. Any thoughts?

@okbel
Copy link
Contributor Author

okbel commented Feb 2, 2017

This is the query:

query myCommentHistory {
    me {
        comments {
            id
            body
            created_at
        }
    }
}

screen shot 2017-02-02 at 8 02 46 am

@wyattjoh

@okbel okbel merged commit 3273749 into master Feb 2, 2017
@wyattjoh wyattjoh deleted the design-pass-tweaks branch February 2, 2017 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants