Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORL-1161] View Conversation Bug #3006

Merged
merged 2 commits into from Jun 26, 2020
Merged

[CORL-1161] View Conversation Bug #3006

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4faccba
fix: fixed anchor link for view conversation
wyattjoh Jun 26, 2020
975f96f
Merge branch 'master' into bugfix/CORL-1161
kodiakhq[bot] Jun 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/core/client/stream/tabs/Profile/MyComments/HistoryComment.tsx
View file
Open in desktop
Expand Up @@ -87,6 +87,7 @@ const HistoryComment: FunctionComponent<HistoryCommentProps> = (props) => {
</div>
)}
<Button
anchor
target="_parent"
href={props.conversationURL}
onClick={props.onGotoConversation}
Expand Down
1 change: 1 addition & 0 deletions src/core/client/stream/tabs/Profile/MyComments/__snapshots__/HistoryComment.spec.tsx.snap
View file
Open in desktop
Expand Up @@ -63,6 +63,7 @@ exports[`renders correctly 1`] = `
</Localized>
</div>
<ForwardRef(forwardRef)
anchor={true}
className="HistoryComment-viewConversation coral coral-myComment-viewConversationButton"
classes={
Object {
Expand Down
8 changes: 4 additions & 4 deletions src/core/client/stream/test/profile/__snapshots__/myComments.spec.tsx.snap
View file
Open in desktop
Expand Up @@ -59,7 +59,7 @@ exports[`renders profile 1`] = `
<div
className="Box-root Flex-root HistoryComment-footer Flex-flex Flex-doubleItemGutter Flex-alignCenter Flex-directionRow gutter"
>
<button
<a
className="BaseButton-root Button-root Button-sizeRegular HistoryComment-sizeRegular Button-colorRegular HistoryComment-colorRegular Button-variantTextUnderlined HistoryComment-variantTextUnderlined HistoryComment-viewConversation coral coral-myComment-viewConversationButton"
data-color="regular"
data-variant="textUnderlined"
Expand All @@ -84,7 +84,7 @@ exports[`renders profile 1`] = `
</i>
View Conversation
</div>
</button>
</a>
</div>
</div>
<div
Expand Down Expand Up @@ -140,7 +140,7 @@ exports[`renders profile 1`] = `
<div
className="Box-root Flex-root HistoryComment-footer Flex-flex Flex-doubleItemGutter Flex-alignCenter Flex-directionRow gutter"
>
<button
<a
className="BaseButton-root Button-root Button-sizeRegular HistoryComment-sizeRegular Button-colorRegular HistoryComment-colorRegular Button-variantTextUnderlined HistoryComment-variantTextUnderlined HistoryComment-viewConversation coral coral-myComment-viewConversationButton"
data-color="regular"
data-variant="textUnderlined"
Expand All @@ -165,7 +165,7 @@ exports[`renders profile 1`] = `
</i>
View Conversation
</div>
</button>
</a>
</div>
</div>
<button
Expand Down