Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream UI bugfixes #3041

Merged
merged 24 commits into from Jul 30, 2020
Merged

Stream UI bugfixes #3041

merged 24 commits into from Jul 30, 2020

Conversation

cvle
Copy link
Member

@cvle cvle commented Jul 23, 2020 •
edited

What does this PR do?

Address issues like:

  • UserBox Authenticated: Should be align-items: flex-end
  • Read more of this conversation has weird padding.
  • Indent missing for last level reply
  • Topbar Left should be "flex alignItems center"
  • aria-pressed for reaction buttons needed to style pressed states
  • share button missing classname
  • counter missing classname
  • title of verify email address has no styling
  • Simplify styling some of the buttons
  • Add more stable css classnames
  • RTE radius
  • Remove line-height form css variables
  • Make line-height values relative

@nick-funk nick-funk self-requested a review July 23, 2020 17:51
@kgardnr kgardnr added this to the v6.4.0 milestone Jul 27, 2020
@nick-funk nick-funk mentioned this pull request Jul 27, 2020
Merged
@kgardnr kgardnr modified the milestones: v6.4.0, v6.3.1 Jul 29, 2020
cvle and others added 5 commits July 29, 2020 22:02
@cvle
harmonize data-variant on buttons
7b514c6
@wyattjoh @tessalt @cvle
[CORL-1215] Install Style Tweaks (#3046)
f75e747 
* fix logic around repeat posts with or without media embeds: (#3042)

* fix: restore ReportCommentEvent (#3037)

Co-authored-by: Wyatt Johnson <wyattjoh@gmail.com>

* fix: fixed issue with graphiql (#3043)

* README.md Update (#3045)

* chore: update README.md

* fix: removed README from doctoc

* fix: replaced emoji codes with emjoi

* fix: removed emoji's due to browser rendering issues

* fix: fixed bugs with install styles

Co-authored-by: Tessa Thornton <tessathornton@gmail.com>
Co-authored-by: Vinh <vinh@vinh.tech>
@cvle
fix: remove lineheight css variables and make them relative
ae370a2
@cvle
Merge branch 'master' into ui-bugfixes
3b154d6
@cvle
fix: adjust line-heights
8bbb323
@kgardnr kgardnr self-requested a review July 30, 2020 21:40
kgardnr
kgardnr approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@kgardnr kgardnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got approval from Kiwi

@cvle cvle merged commit 802f656 into master Jul 30, 2020
@cvle cvle deleted the ui-bugfixes branch July 30, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgardnr kgardnr kgardnr approved these changes

@nick-funk nick-funk nick-funk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.3.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cvle @kgardnr @nick-funk @wyattjoh