[CORL-1201] Better use flex to align callout contents #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattjoh
reviewed
Jul 31, 2020
nick-funk
force-pushed
the
bug/CORL-1201-callout-dismiss
branch
from
d31cec2
to
3727bc2
Compare
nick-funk
force-pushed
the
bug/CORL-1201-callout-dismiss
branch
from
3727bc2
to
665a1fa
Compare
wyattjoh
approved these changes
Jul 31, 2020
tessalt
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Better sets the flex alignment of the callout's content controls. Sets a flex-basis to properly size the icon and dismiss button (when present) and allows the contents (titles, body) to fill the remaining space.
As well, the icon and the dismiss/close button now align with one another because of the new justification and alignments. This also keeps the content body from shifting the icon and close button around.
Lastly, this fixes any wrapping issues that were previously possible depending on your screen width.
What changes to the GraphQL/Database Schema does this PR introduce?
None
How do I test this PR?
Make a callout appear somewhere on the stream. I recommend going into your
Profile > Preferences > Email Notificationsand changing something to get one to show up.