[CORL-1235] Support Mobile Twitter Links #3066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattjoh
force-pushed
the
bugfix/CORL-1235
branch
from
4a43dc4
to
87173a8
Compare
tessalt
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Previous pattern did not match
mobile.twitter.comlinks, and incorrectly returned links without a scheme. This change serves to standardize the way we detect and format links as well as adding support for mobile Twitter links.What changes to the GraphQL/Database Schema does this PR introduce?
None.
How do I test this PR?
Post a comment containing the text
mobile.twitter.com/coralproject/status/1280903734478987265and see that it includes the media object properly.