Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6.3.2 mobile and responsive UI fixes #3096

Merged
merged 8 commits into from Aug 11, 2020
Merged

6.3.2 mobile and responsive UI fixes #3096

merged 8 commits into from Aug 11, 2020

Conversation

nick-funk
Copy link
Contributor

@nick-funk nick-funk commented Aug 11, 2020 •
edited

This fixes the following issues for the UI on mobile screens:

  • CORL-1270: line height on badges should align with username/timespan
  • CORL-1269: read more conversation link is cut off on mobile
  • CORL-1271: on mobile, the report button should only show an icon
  • CORL-1268: flexing the username, badges, timespan doesn't match mobile spec

Figma Spec for mobile: https://www.figma.com/file/r72qu36XnP4WmFQPHUET9U/Coral-Stream?node-id=2894%3A3449

@kgardnr kgardnr added this to the v6.3.2 milestone Aug 11, 2020
@nick-funk nick-funk marked this pull request as ready for review August 11, 2020 17:59
@kgardnr kgardnr added the bug label Aug 11, 2020
@wyattjoh wyattjoh temporarily deployed to pure-lowlands-73130 August 11, 2020 19:38 Inactive
@kgardnr kgardnr self-requested a review August 11, 2020 20:12
@kgardnr kgardnr added the 🚀 merge it! Pull requests that should be merged after status checks pass with a review label Aug 11, 2020
@kodiakhq kodiakhq bot merged commit 6c32316 into master Aug 11, 2020
@kodiakhq kodiakhq bot deleted the feature/mobile-ui-fixes branch August 11, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgardnr kgardnr kgardnr approved these changes

@wyattjoh wyattjoh Awaiting requested review from wyattjoh

@tessalt tessalt Awaiting requested review from tessalt

@cvle cvle Awaiting requested review from cvle

Assignees
No one assigned
Labels
bug 🚀 merge it! Pull requests that should be merged after status checks pass with a review
Projects
None yet
Milestone
v6.3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nick-funk @kgardnr @wyattjoh