[CORL-1264] Mark and allow word list timed out comments #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will mark the comment's metdata as a word list time out if it happens and also tag them with suspect or banned word. Then we show "possible suspect/banned word" markers on the moderate card so moderators can manually review them. CORL-1264
nick-funk
force-pushed
the
bug/CORL-1264-wordlist-timeout
branch
from
cd8e905
to
7f16cb1
Compare
wyattjoh
approved these changes
Aug 11, 2020
wyattjoh
added
the
🚀 merge it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Will mark the comment's metdata as a word list
time out if it happens and also tag them with
suspect or banned word.
Then we show "possible suspect/banned word"
markers on the moderate card so moderators can
manually review them.
What changes to the GraphQL/Database Schema does this PR introduce?
Adds a
CommentRevisionWordListMetadatato theCommentRevisionMetadatatype onCommentRevision.How do I test this PR?
src/core/server/services/comments/pipeline/phases/wordList.tsso thatconst banned(line 33) orconst suspect(line 61) arenullinstead of thelist.test(...)produced value.reportedwith aPossible Suspect/Banned Wordmarker.