ensure getlinkedRecord is truthy before retrieving value in queue subscription #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattjoh
reviewed
Aug 17, 2020
Comment on lines
+38
to
+39
| r.getLinkedRecord("node") && | ||
| r.getLinkedRecord("node")!.getValue("id") !== commentID |
There was a problem hiding this comment.
You can actually write this as:
Suggested change
| r.getLinkedRecord("node") && | |
| r.getLinkedRecord("node")!.getValue("id") !== commentID | |
| r.getLinkedRecord("node")?.getValue("id") !== commentID |
Though this is related already to the issue that @cvle is already assigned (CORL-1281), so we might need to wait for this fix.
kgardnr
changed the title
|
I'm looking into this already, there is probably more to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok I'm not sure this is actually the real problem but this addresses the
cannot call getValue on undefinederror was seeing in prod on clicking "view x new comments" in the moderation queue.why was the
!used in the first place, is there a reasongetLinkedRecordshould always be truthy here that I'm missing? If it's undefined, what could that mean? much to discuss, maybe