[CORL-1296] New Comment Count #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am only seeing the |
nick-funk
approved these changes
Aug 28, 2020
| @@ -6,7 +6,7 @@ import { LanguageCode } from "coral-common/helpers"; | |||
| import { | |||
| GiphyGifRetrieveResponse, | |||
| GiphyGifSearchResponse, | |||
| } from "coral-common/rest/external/giphy"; | |||
| } from "coral-common/types/giphy"; | |||
There was a problem hiding this comment.
Why were Giphy files modified in this PR?
There was a problem hiding this comment.
I moved types around to keep things consistent!
wyattjoh
added
the
🚀 merge it!
kodiakhq
bot
removed
the
🚀 merge it!
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
wyattjoh
force-pushed
the
feature/CORL-1296
branch
from
9447f79
to
575a17c
Compare
wyattjoh
added
the
🚀 merge it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With the
NEW_COMMENT_COUNTfeature flag, comment streams viewed will record the current comment count. When used in conjunction withcount.js, it will show/ 5 Newwhen the number of comments exceeds what was previously recorded.What changes to the GraphQL/Database Schema does this PR introduce?
FEATURE_FLAG.NEW_COMMENT_COUNTHow do I test this PR?
NEW_COMMENT_COUNTfeature flag./ 1 Newadded to the comment count text.