[CORL-1357] Intersection Provider Fixes #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyattjoh
force-pushed
the
bugfix/CORL-1357
branch
from
4c8e389
to
548d778
Compare
cvle
approved these changes
Sep 2, 2020
cvle
added
the
🚀 merge it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes race condition where callbacks were not checked before execution. This also replaces usage of the
withInViewwithuseInView.What changes to the GraphQL/Database Schema does this PR introduce?
None.
How do I test this PR?
Load the comment stream and do not notice errors relating to intersection observers. Try to scroll on admin where you'd expect infinite scroll to occur, notice it working!