Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-2978]: Add rejection reasons to comment card and user drawer #4439

Merged

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Nov 29, 2023

What does this PR do?

This adds rejection reasons, if the comment is rejected and there are rejection reasons, to comment moderation cards and in the user drawer.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

Adds in the customReason introduced in another PR so that it can be displayed here if available.

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can reject some comments for different reasons (including Other and Illegal content), with and without detailed explanations. See that if a comment is rejected, the rejection decision info will be shown when the DETAILS is clicked in the comment card in mod queues and user drawer. That the comment is rejected and the rejection reason code should always be shown, in addition to the timestamp of when the comment was rejected. The legal grounds, detailed explanation, and custom reason should only show if they exist. If there is a decision, it should be the first tab shown.

If a comment is not rejected and there is no decision to show, then INFO should still be the tab shown.

Where any tests migrated to React Testing Library?

How do we deploy this PR?

Copy link

netlify bot commented Nov 29, 2023

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit db71ace
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65675f00627a6b000810833d

Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kabeaty kabeaty added the 🚀 merge it! Pull requests that should be merged after status checks pass with a review label Dec 4, 2023
@kabeaty kabeaty added this pull request to the merge queue Dec 4, 2023
Merged via the queue into develop with commit 11c5cc2 Dec 4, 2023
6 checks passed
@kabeaty kabeaty deleted the feat/CORL-2978-rejection-reasons-add-comment-card-user-drawer branch December 4, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 merge it! Pull requests that should be merged after status checks pass with a review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants