[CORL-2805]: Delete user button in admin #4481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
nick-funk
approved these changes
Jan 12, 2024
| }; | ||
|
|
||
| export const UserDeletionStatus: Required< | ||
| GQLUserDeletionStatusTypeResolver<UserDeletionStatusInput> |
There was a problem hiding this comment.
Are we using an input as a resolver result type here? Maybe time for a new interface or maybe there is a generated schema type that would make more sense?
| @@ -57,6 +58,10 @@ export const UserStatus: Required<GQLUserStatusTypeResolver<UserStatusInput>> = | |||
| ...user.consolidateUsernameStatus(username), | |||
| userID, | |||
| }), | |||
| deletion: ({ userID, deletion }): UserDeletionStatusInput => ({ | |||
There was a problem hiding this comment.
Same here, seems like the resolver might have generated a result type instead of an Input.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
These changes add a button to the user account history drawer to be able to delete a user's account if you are an admin. You can also cancel the deletion request there if one has already been made. The history of account deletion requests and cancellations is also now displayed in the user account history drawer.
These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
These changes add user deletion history to a user's status history to keep track of requests and cancellations for deletion. The changes also add mutations for scheduling deletions and cancelling deletions to be used by admin users other than the target user.
Does this PR introduce any new environment variables or feature flags?
no
If any indexes were added, were they added to
INDEXES.md?n/a
How do I test this PR?
You can test this PR by logging in as an admin user and clicking on another user's username in the Community tab of the admin to open that user's account history drawer. Then click
Account History. You should see a button at the top that saysDelete Account. When you click it, you will see that it now says the account has been scheduled for deletion along with when and the option to cancel it. You should also see this deletion request at the top of the account history with the username of the user who you used to request it. ClickCancel User Deletionbutton. See that the request is canceled, with the deletion cancellation request shown at the top of the account history and theDelete Accountbutton shown again.If there is an error when scheduling the account deletion, its message will be displayed in the account deletion popover. If there is an error canceling the account deletion, it will be displayed in account history near the cancel deletion callout. You can also test these if you like.
You can also confirm that:
My profile->Account, the deletion history is updated and shown in the user account history drawer in the admin accordinglyWere any tests migrated to React Testing Library?
How do we deploy this PR?