Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-3022]: add new outlook accounts to protected email domains #4484

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Jan 12, 2024

What does this PR do?

Adds more Outlook domains to the protected email domains list

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

  • rebuild common (because the list is shared in the common library)

  • rebuild server and client and spin up Coral

  • attempt to spam ban a domain using:

    • outlook.co.nz
    • outlook.at
    • outlook.in
    • outlook.com.au
    • outlook.fr
    • outlook.de
    • outlook.jp
  • see that each is blocked like all the other protected domains

Were any tests migrated to React Testing Library?

How do we deploy this PR?

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 84d4d60
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65a186f43e33bb000867d33b

Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kabeaty kabeaty added this pull request to the merge queue Jan 23, 2024
Merged via the queue into develop with commit 784afc3 Jan 23, 2024
6 checks passed
@kabeaty kabeaty deleted the chore/CORL-3022-add-more-outlook-domains branch January 23, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants