Add a secretBadges array to the user model
#4506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is only configurable via Mongo, it is used for special cases by the organization.
✅ Deploy Preview for gallant-galileo-14878c canceled.
|
nick-funk
changed the title
secretBadges array to the user modelsecretBadges array to the user model
nick-funk
commented
Jan 25, 2024
Comment on lines
+110
to
+112
| if (!badges && !secretBadges) { | ||
| return undefined; | ||
| } |
There was a problem hiding this comment.
I did this to retain the original behaviour of the badges possibly being undefined (type is string[] | undefined on the User model) and thus making sure we aren't messing things up by returning an empty array when something might expect undefined instead.
I doubt there is any issue with returning an empty array, but why mess with an edge case that might exist when we can easily return what we know works well?
kabeaty
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
secretBadgesarray to the user model which is only configurable via Mongo and used for special cases by the organization.These changes will impact:
What changes to the GraphQL/Database Schema does this PR introduce?
None
Does this PR introduce any new environment variables or feature flags?
No
If any indexes were added, were they added to
INDEXES.md?N/A
How do I test this PR?
secretBadgesarray field to their user document and add an entry (they are string values in an array)Were any tests migrated to React Testing Library?
No
How do we deploy this PR?
If we want to formally release this, rebase this off of
develop(instead of v8.7.1) and merge it as usual intodevelop.