Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-3051] Fix padding on user drawer badges #4519

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

nick-funk
Copy link
Contributor

What does this PR do?

  • Add padding to user drawer badges (next to user name)
  • Align badges with the user name text
image

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

None

Does this PR introduce any new environment variables or feature flags?

No

If any indexes were added, were they added to INDEXES.md?

N/A

How do I test this PR?

  • modify a user's badges with Mongo compass (or similar)
  • sign in as an admin/mod and find the user under Admin > Community
  • open the user's drawer (click on username)
  • see the badges listed beside their name
  • see that they are padded and aligned nicely with the user name

Were any tests migrated to React Testing Library?

No

How do we deploy this PR?

No special considerations.

also fixes alignment between user name and badges
Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit 17c1480
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/65bc136172776d0008acae81

Copy link
Contributor

@kabeaty kabeaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kabeaty kabeaty added this pull request to the merge queue Feb 12, 2024
Merged via the queue into develop with commit e01b6a3 Feb 12, 2024
6 checks passed
@kabeaty kabeaty deleted the fix/CORL-3051-user-drawer-badges branch February 12, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants