Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORL-3121]: add domain ban history description to account history #4590

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

kabeaty
Copy link
Contributor

@kabeaty kabeaty commented Mar 29, 2024

What does this PR do?

These changes update to add to the account history description that an account is domain banned if the ban is done by the system.

These changes will impact:

  • commenters
  • moderators
  • admins
  • developers

What changes to the GraphQL/Database Schema does this PR introduce?

none

Does this PR introduce any new environment variables or feature flags?

no

If any indexes were added, were they added to INDEXES.md?

n/a

How do I test this PR?

You can create a new user with an account that uses an email domain that is automatically banned. See that when you go to their account history in their user drawer, it says that they were Account domain banned in the description and that the action was taken by System.

Were any tests migrated to React Testing Library?

How do we deploy this PR?

Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for gallant-galileo-14878c canceled.

Name Link
🔨 Latest commit e37bd45
🔍 Latest deploy log https://app.netlify.com/sites/gallant-galileo-14878c/deploys/6606de7da2adb70008799e8c

Copy link
Contributor

@nick-funk nick-funk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ternaries nesting had me going for a minute, but this makes sense now.

@tessalt tessalt added this to the 9.0.2 milestone Apr 3, 2024
@tessalt tessalt added this pull request to the merge queue Apr 3, 2024
Merged via the queue into develop with commit 64f4972 Apr 3, 2024
6 checks passed
@tessalt tessalt deleted the fix/CORL-3121-domain-ban-history-descrip branch April 3, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants