Remove intermediate string allocation when writing match details log (#…

…781)
corazawaf · May 6, 2023 · 21dfb41 · 21dfb41
1 parent 6969057
commit 21dfb41
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/internal/corazarules/rule_match.go b/internal/corazarules/rule_match.go
@@ -106,9 +106,7 @@ func (mr *MatchedRule) Rule() types.RuleMetadata {
 	return mr.Rule_
 }
 
-func (mr MatchedRule) details(matchData types.MatchData) string {
-	log := &strings.Builder{}
-
+func (mr MatchedRule) writeDetails(log *strings.Builder, matchData types.MatchData) {
 	msg := matchData.Message()
 	data := matchData.Data()
 	if len(msg) > 200 {
@@ -125,7 +123,6 @@ func (mr MatchedRule) details(matchData types.MatchData) string {
 	}
 	log.WriteString(fmt.Sprintf(" [hostname %q] [uri %q] [unique_id %q]",
 		mr.ServerIPAddress_, mr.URI_, mr.TransactionID_))
-	return log.String()
 }
 
 func (mr MatchedRule) matchData(matchData types.MatchData) string {
@@ -161,7 +158,7 @@ func (mr MatchedRule) AuditLog(code int) string {
 			log.WriteString("Coraza: Warning. ")
 		}
 		log.WriteString(mr.matchData(matchData))
-		log.WriteString(mr.details(matchData))
+		mr.writeDetails(log, matchData)
 		log.WriteString("\n")
 	}
 	return log.String()
@@ -192,7 +189,7 @@ func (mr MatchedRule) ErrorLog(code int) string {
 		}
 		log.WriteString(msg)
 		log.WriteString(" ")
-		log.WriteString(mr.details(matchData))
+		mr.writeDetails(log, matchData)
 		log.WriteString("\n")
 	}
 	return log.String()