Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove intermediate string allocation when writing match details log #781

Merged
merged 1 commit into from May 6, 2023

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented May 2, 2023

No description provided.

@anuraaga anuraaga requested a review from a team as a code owner May 2, 2023 03:58
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.01 ⚠️

Comparison is base (42d4ae8) 81.86% compared to head (c9c45fa) 81.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           v3/dev     #781      +/-   ##
==========================================
- Coverage   81.86%   81.85%   -0.01%     
==========================================
  Files         153      153              
  Lines        8192     8189       -3     
==========================================
- Hits         6706     6703       -3     
  Misses       1267     1267              
  Partials      219      219              
Flag Coverage Δ
default 78.09% <66.66%> (-0.01%) ⬇️
examples 26.00% <66.66%> (-0.03%) ⬇️
ftw 49.10% <66.66%> (-0.02%) ⬇️
ftw-multiphase 49.21% <66.66%> (-0.02%) ⬇️
tinygo 77.23% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/corazarules/rule_match.go 52.00% <66.66%> (-1.40%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jcchavezs jcchavezs merged commit 21dfb41 into corazawaf:v3/dev May 6, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants