chore: finalizes go 1.21 bump, point to local version for crs tests, minor docs #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
M4tteoP
commented
Jul 18, 2024
M4tteoP
commented
- finalizes go 1.21 bump
- Minor docs that follow fix: deny action with default status 403 #1097
- address fix(deps): update module github.com/corazawaf/coraza/v3 to v3.2.1 #1082, for CRS tests I think it is reasonable to point to the local Coraza rather than sticking to a fixed version
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1102 +/- ##
==========================================
+ Coverage 82.72% 83.14% +0.42%
==========================================
Files 162 164 +2
Lines 9080 7687 -1393
==========================================
- Hits 7511 6391 -1120
+ Misses 1319 1042 -277
- Partials 250 254 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fzipi
reviewed
Jul 19, 2024
| @@ -37,8 +40,7 @@ func (a *denyFn) Evaluate(r plugintypes.RuleMetadata, tx plugintypes.Transaction | |||
| status := r.Status() | |||
| // deny action defaults to status 403 | |||
| if status == noStatus { | |||
| // TODO(M4tteop): use http.StatusForbidden once we drop Go 1.20 support. http pkg unsupported with TinyGo and Go <1.20 | |||
| status = 403 | |||
| status = http.StatusForbidden | |||
There was a problem hiding this comment.
❤️ on using constants instead of numbers
fzipi
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.