chore: increases rule.go test coverage #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M4tteoP
changed the title
jcchavezs
reviewed
May 5, 2023
internal/corazawaf/rule_test.go
Outdated
|
|
||
| type dummyFlowAction struct{} | ||
|
|
||
| func (a *dummyFlowAction) Init(_ plugintypes.RuleMetadata, data string) error { |
There was a problem hiding this comment.
Suggested change
| func (a *dummyFlowAction) Init(_ plugintypes.RuleMetadata, data string) error { | |
| func (a *dummyFlowAction) Init(_ plugintypes.RuleMetadata, _ string) error { |
jcchavezs
reviewed
May 5, 2023
internal/corazawaf/rule_test.go
Outdated
| func (a *dummyFlowAction) Init(_ plugintypes.RuleMetadata, data string) error { | ||
| return nil | ||
| } | ||
| func (a *dummyFlowAction) Evaluate(r plugintypes.RuleMetadata, tx plugintypes.TransactionState) { |
There was a problem hiding this comment.
You don´t need the receiver here (namely a) as you aren't accesing any field.
jcchavezs
reviewed
May 5, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v3/dev #786 +/- ##
==========================================
+ Coverage 81.78% 81.92% +0.13%
==========================================
Files 153 153
Lines 8204 8205 +1
==========================================
+ Hits 6710 6722 +12
+ Misses 1274 1266 -8
+ Partials 220 217 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
jcchavezs
approved these changes
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR meant to increase
rule.gotest coverage