Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: increases rule.go test coverage #786

Merged
merged 5 commits into from
May 9, 2023
Merged

chore: increases rule.go test coverage #786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87f3884
increases rule.go test coverage
M4tteoP May 5, 2023
570985b
Merge branch 'v3/dev' into rulego-tests
M4tteoP May 5, 2023
aee23d8
address nits after review
M4tteoP May 5, 2023
432e4c3
chore: fixes nits
jcchavezs May 6, 2023
aa65b2b
Merge branch 'v3/dev' into rulego-tests
jcchavezs May 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions internal/corazawaf/rule.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,8 +317,9 @@ func (r *Rule) doEvaluate(phase types.RulePhase, tx *Transaction, cache map[tran

func (r *Rule) transformArg(arg types.MatchData, argIdx int, cache map[transformationKey]*transformationValue) ([]string, []error) {
if r.MultiMatch {
// TODO in the future, we don't need to run every transformation
// We could try for each until found
// TODOs:
// - We don't need to run every transformation. We could try for each until found
// - Cache is not used for multimatch
return r.executeTransformationsMultimatch(arg.Value())
} else {
switch {
Expand Down