Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved command input #4

Merged
merged 2 commits into from
Feb 11, 2023
Merged

Improved command input #4

merged 2 commits into from
Feb 11, 2023

Conversation

K0IN
Copy link
Contributor

@K0IN K0IN commented Feb 11, 2023

  • Added history to command input
  • Added builtin commands as a example

* Added history to command input
* Added builtin commands as a example
@K0IN
Copy link
Contributor Author

K0IN commented Feb 11, 2023

Hi, I just thought it would be cool to have a history for the commands used so far (limited to 5).
Also, I added a few built in (you can change or even remove them if you don't like them) commands, just to have a starting point for new users.

Btw great extension love it.

@corbt
Copy link
Owner

corbt commented Feb 11, 2023

Nice, just tried this out. Solid addition!

Would you mind swapping out the sample instructions you provided for the following ones? I'll merge right after that!

  • Fix syntax errors
  • Add type hints to all function definitions
  • Remove logging statements
  • Remove dead code

@K0IN
Copy link
Contributor Author

K0IN commented Feb 11, 2023

Your defaults are now set, maybe in the future I will open a pr to move them out into the (vsc) config :)
Thanks for your quick reply!

Copy link
Owner

@corbt corbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Will release as 0.5.0 🎉

@corbt corbt merged commit 0960e9d into corbt:main Feb 11, 2023
@corbt corbt mentioned this pull request Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants