Added AZ terraform scripts #37
Conversation
There was a problem hiding this comment.
Thanks for the PR, Neal.
I think the changes look good for the most part, but one thing needs to be handled before we can merge this PR. There is a reference to a private repository, which contains the essential modules. In order for these proposed PR changes to be valid, access to those modules need to be given, either in the form of making the repository public or by having those modules added as part of this PR to this repository.
| } | ||
|
|
||
| module "aks" { | ||
| source = "git@github.com:corda/terraform-modules-ext//modules/az-kubernetes?ref=master" |
There was a problem hiding this comment.
This repository seems to be a private repository.
It also seems to be an essential part of the proposed changes.
Without access to this repository the changes cannot be validated.
There are two options:
- make the private repository public
- add the modules from the private repository to be part of this PR
|
|
||
| 1. Change directory into the Terraform folder in this repository. | ||
|
|
||
| 2. Create your `terraform.tfvars` file using the `terraform.tfvars.example`. |
There was a problem hiding this comment.
terraform.tfvars.example does not exist, only terraform.tfvars. I guess that's fine, so probably just update this line of documentation to reflect the reality.
No description provided.