CORE-8856 Adding lambda to suspendible function to trigger bug #6149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for PR 6149 build 5 Build Successful: |
lankydan
reviewed
May 20, 2024
| @@ -366,9 +366,9 @@ class UtxoFinalityFlowV1( | |||
| } | |||
|
|
|||
| if (log.isDebugEnabled) { | |||
| log.debug( | |||
| log.debug { | |||
There was a problem hiding this comment.
You probably need to ensure that the tests are running at debug level, not sure if they do or not.
|
|
This PR is stale because it has been open 7 days with no activity. Remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the development of
5.0, we were seeing flows failing with the errorjava.lang.VerifyError: Bad local variable type. It was discovered that this was triggered by lambda functions being used within suspendible functions.The root cause was then discovered to be a difference in how JVM and ASM store local variables in the frame, which caused the previous exception to be thrown when a function was suspended and resumed. A bug was raised against the maintainers of ASM HERE, and I see that this has now been actioned.
This PR adds a lambda to a suspendible function in an attempt to trigger the previous issue, or to show that the fix to ASM has resolved it. It needs not be merged; it's intended only as an investigation.