-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-8856 Adding lambda to suspendible function to trigger bug #6149
Conversation
Jenkins build for PR 6149 build 5 Build Successful: |
@@ -366,9 +366,9 @@ class UtxoFinalityFlowV1( | |||
} | |||
|
|||
if (log.isDebugEnabled) { | |||
log.debug( | |||
log.debug { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably need to ensure that the tests are running at debug level, not sure if they do or not.
|
This PR is stale because it has been open 7 days with no activity. Remove the |
During the development of
5.0
, we were seeing flows failing with the errorjava.lang.VerifyError: Bad local variable type
. It was discovered that this was triggered by lambda functions being used within suspendible functions.The root cause was then discovered to be a difference in how JVM and ASM store local variables in the frame, which caused the previous exception to be thrown when a function was suspended and resumed. A bug was raised against the maintainers of ASM HERE, and I see that this has now been actioned.
This PR adds a lambda to a suspendible function in an attempt to trigger the previous issue, or to show that the fix to ASM has resolved it. It needs not be merged; it's intended only as an investigation.