Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-8856 Adding lambda to suspendible function to trigger bug #6149

Closed
wants to merge 5 commits into from
Closed

CORE-8856 Adding lambda to suspendible function to trigger bug #6149

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c5a8b6
CORE-8856 Adding lambda to suspendable function to trigger bug
ben-millar May 20, 2024
062b53b
CORE-8856 Added @RepeatedTest(100) annotation to test which exercises…
ben-millar May 20, 2024
fbfb9a2
CORE-8856 Moving log to info level to ensure it's being evaluated
ben-millar May 21, 2024
bdc132d
CORE-8856 Change every log in flow to info-level lambda log
ben-millar May 28, 2024
93b8fb2
CORE-8856 Fixed detekt issues
ben-millar May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...t/src/smokeTest/kotlin/net/corda/applications/workers/smoketest/ledger/UtxoLedgerTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import net.corda.e2etest.utilities.startRestFlow
import net.corda.v5.crypto.SecureHash
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.BeforeAll
import org.junit.jupiter.api.RepeatedTest
import org.junit.jupiter.api.Test
import org.junit.jupiter.api.TestInfo
import org.junit.jupiter.api.TestInstance
Expand Down Expand Up @@ -109,7 +110,7 @@ class UtxoLedgerTests : ClusterReadiness by ClusterReadinessChecker() {
}


@Test
@RepeatedTest(100)
fun `Utxo Ledger - create a transaction containing states and finalize it then evolve it`(testInfo: TestInfo) {
val idGenerator = TestRequestIdGenerator(testInfo)
val input = "test input"
Expand Down
4 changes: 2 additions & 2 deletions ...w/src/main/kotlin/net/corda/ledger/utxo/flow/impl/flows/finality/v1/UtxoFinalityFlowV1.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,9 +366,9 @@ class UtxoFinalityFlowV1(
}

if (log.isDebugEnabled) {
log.debug(
log.debug {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably need to ensure that the tests are running at debug level, not sure if they do or not.

"Successfully notarized transaction $transactionId using notary $notary and received ${notarySignatures.size} signature(s)"
)
}
}

return notarizedTransaction to notarySignatures
Expand Down