Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-15310: Upgrade SLF4J to version 2 #6150

Merged
merged 51 commits into from
Jun 12, 2024
Merged

CORE-15310: Upgrade SLF4J to version 2 #6150

merged 51 commits into from
Jun 12, 2024

Conversation

josephzunigadaly
Copy link
Contributor

@josephzunigadaly josephzunigadaly commented May 20, 2024 •
edited by filipesoliveira
Loading

This PR depends on corda/corda-api#1645

@josephzunigadaly josephzunigadaly self-assigned this May 20, 2024
@josephzunigadaly josephzunigadaly force-pushed the jzd/CORE-15310-slf4j-2-3 branch 3 times, most recently from 102de73 to ca4995b Compare May 23, 2024 08:20
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented May 23, 2024 •
edited
Loading

Jenkins build for PR 6150 build 58

Build Successful:
Jar artifact version produced by this PR: 5.3.0.0-alpha-1718181799098
Helm chart version produced by this PR: 5.3.0-alpha.1718181799098
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-6150/corda
Helm chart Polaris score: 82

@josephzunigadaly @filipesoliveira
Update to SLF4J v2
3b28c07
@josephzunigadaly @filipesoliveira
Fix removal of second SLF4J export
08aea50
@josephzunigadaly @filipesoliveira
Remove debug code
9057b9e
@josephzunigadaly @filipesoliveira
Fix export
5deb13f
@josephzunigadaly @filipesoliveira
Export org.slf4j.spi v1
89deeb8
@josephzunigadaly @filipesoliveira
Set API version to build from API PR
0ebaa06
@josephzunigadaly @filipesoliveira
Remove slf4j-v2-api
9503c43
@josephzunigadaly @filipesoliveira
Remove log4j-slf4j2
56babd4
@josephzunigadaly @filipesoliveira
Revert unwanted change
df1cd2f
@josephzunigadaly @filipesoliveira
Export org.slf4j.event v1
618c096
@josephzunigadaly @filipesoliveira
Remove slf4j constraint
6e4397c
@josephzunigadaly @filipesoliveira
Add org.apache.aries.spifly to projects needing service loader support
da2507d
@josephzunigadaly @filipesoliveira
Update API version
dc1634c
@josephzunigadaly @filipesoliveira
Upgrade bnd to version 7
6d87c46
@josephzunigadaly @filipesoliveira
Add org.apache.aries.spifly to projects needing service loader support
9c68f0d
@josephzunigadaly @filipesoliveira
Export all SLF4J packages from the framework bundle, like the main sy…
02513b7 
…stem does

Convert tabs to spaces
@josephzunigadaly @filipesoliveira
Revert "Export all SLF4J packages from the framework bundle, like the…
8e771a6 
… main system does"

This reverts commit edb33d3.
@josephzunigadaly @filipesoliveira
Add a new module that exports SLF4J V1 API, only for testOSGi targets
40df7d8
@josephzunigadaly @filipesoliveira
Add dependency on new internal test library
5d13e2a
@josephzunigadaly @filipesoliveira
Use task.bundleVersion as version number
6e0cceb
@josephzunigadaly @filipesoliveira
Enable clean because OSGi tests are sensitive to previous builds
08eb617
@josephzunigadaly @filipesoliveira
Add dependency on new internal test library
c94fdf1
@vkolomeyko vkolomeyko self-assigned this Jun 10, 2024
@vkolomeyko
Copy link
Contributor

build e2e

@vkolomeyko vkolomeyko marked this pull request as ready for review June 11, 2024 11:08
@vkolomeyko vkolomeyko requested review from a team as code owners June 11, 2024 11:08
@vkolomeyko vkolomeyko mentioned this pull request Jun 11, 2024
Merged
@vkolomeyko vkolomeyko self-requested a review June 11, 2024 11:11
vkolomeyko
vkolomeyko previously approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vkolomeyko
Copy link
Contributor

I have also ran QA Reg pack for Flows for the Helm charts for this PR and it has passed successfully: https://ci05.dev.r3.com/blue/organizations/jenkins/QA%2FCRAFT5%2FCraft_Tests%2FC5%2FLatest%2FOpensource%2FEKS%2FOS-qa-regpack-tests-flow-eks/detail/main/23/pipeline/

filipesoliveira
filipesoliveira previously approved these changes Jun 12, 2024
View reviewed changes
gradle.properties Outdated Show resolved Hide resolved
gradle.properties Outdated Show resolved Hide resolved
@filipesoliveira filipesoliveira self-requested a review June 12, 2024 08:36
@filipesoliveira filipesoliveira dismissed stale reviews from vkolomeyko and themself via 96936bb June 12, 2024 08:42
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@vkolomeyko vkolomeyko self-requested a review June 12, 2024 09:14
vkolomeyko
vkolomeyko approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filipesoliveira filipesoliveira merged commit e9d2005 into release/os/5.3 Jun 12, 2024
5 checks passed
@filipesoliveira filipesoliveira deleted the jzd/CORE-15310-slf4j-2-3 branch June 12, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkolomeyko vkolomeyko vkolomeyko approved these changes

@owenstanford owenstanford owenstanford approved these changes

@filipesoliveira filipesoliveira Awaiting requested review from filipesoliveira

Assignees

@filipesoliveira filipesoliveira

@vkolomeyko vkolomeyko

@josephzunigadaly josephzunigadaly

Labels
DO_NOT_CLOSE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephzunigadaly @filipesoliveira @vkolomeyko @owenstanford